Inconsistent line endings in symbol.py #125
Closed
chknd1nner
started this conversation in
General
Replies: 1 comment
|
Looks like some of the latest commits fixed the line ending issue. I see there was a PR where it looks as though the entire symbol.py was replaced. This was what I was experiencing before. Now when I compare changes I make to symbol.py, it shows the correct diffs. Someone must not have had their line ending config set correctly at some point. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Hi guys.
I tried submitting a PR a few days ago and found GitHub thinks the whole file is changing instead of just a few lines. I think the issue is with the line endings.
I set my
git config core.autocrlf inputbecause I am on Mac. Therefore, no matter what I do, whenever I commit anything, it's gonna be just LF.According to the readme, you guys are all on
git config core.autocrlf truewhich means that you're working locally on Windows with CRLF, but no mater what, when you commit, your stuff should also be converted to just LF.If that is the case, then why is there still a discrepency in the line endings causing my PRs to appear as a whole file replace? And interestingly, this only happens to me for
symbol.py. The changes I made toagent.pyshow no issue with the diff.Conclusion: There's something funny going on with the line endings of symbol.py in the repository on GitHub. Somehow it's got CRLF despite you all using autocrlf true.
All reactions