Handle disconnected mic/camera selections gracefully - #2104
Open
richiemcilroy wants to merge 7 commits into
Open
Handle disconnected mic/camera selections gracefully#2104richiemcilroy wants to merge 7 commits into
richiemcilroy wants to merge 7 commits into
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a mic/camera, unplugging them (e.g. undocking a laptop), and relaunching left Cap in a stuck error state: the camera preview window flashed with a persistent "Camera unavailable" error on every launch and picker open, the device rows still showed the missing devices as On, and recording refused to start with "Selected camera is no longer available".
Device selections are now treated as remembered preferences resolved at use time:
set_mic_input/set_camera_inputquietly keep the selection when the device is not connected instead of running the show-window/retry/toast loop (same for the duplicate restore loop that ran on every main-window reveal).Device-present paths are unchanged. Validated with
cargo check,cargo test -p cap-desktop --lib(141 passed),tsc --noEmit, andvitest run(91 passed).Greptile Summary
The PR treats selected microphones and cameras as remembered preferences that may temporarily be unavailable.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Reviews (2): Last reviewed commit: "chore: drop redundant disconnected-prop ..." | Re-trigger Greptile
Context used: