London | 26-SDC-July| Mariia Serhiienko | Sprint 3 | Implement shell tools - #659
Open
Konvaly wants to merge 3 commits into
Open
London | 26-SDC-July| Mariia Serhiienko | Sprint 3 | Implement shell tools#659Konvaly wants to merge 3 commits into
Konvaly wants to merge 3 commits into
Conversation
Konvaly
added
the
Needs Review
LonMcGregor
reviewed
Aug 12, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Good start, I have a few comments for some files
| const numberNonBlank = values["number-nonblank"]; | ||
|
|
||
| if (positionals.length === 0) { | ||
| console.error("Usage: node cat.js [-n] [-b] <path>..."); |
Contributor
There was a problem hiding this comment.
Is there a library you could use to manage argument parsing, that would do all this for you?
|
|
||
| const { values, positionals } = parseArgs({ | ||
| options: { | ||
| one: { type: "boolean", short: "1", default: false }, |
Contributor
There was a problem hiding this comment.
Where do you use the "one" argument?
| const paths = positionals.length > 0 ? positionals : ["."]; | ||
|
|
||
| function stripPunctuation(name) { | ||
| return name.replace(/[^\p{L}\p{N}]/gu, ""); |
Contributor
There was a problem hiding this comment.
This looks quite complex. What does this regexp do, and why are you using it?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Implemented my own cat, ls and wc in JavaScript.
No dependencies; I used the built-in 'node:util' parseArgs for the flags instead of commander, since nothing here needs '--help'.
Task ID: CYF-1150