Harden Testnet BENS deployment startup - #179
Merged
Merged
Conversation
JOY (JOY)
marked this pull request as ready for review
August 12, 2026 17:47
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Code Review
This pull request introduces a retry mechanism for deploying the dos-names subgraph in the testnet environment, including health checks to verify subgraph readiness and extraction of the IPFS hash for retry attempts. It also adds corresponding test coverage. The review feedback suggests improving test robustness by asserting the presence of the delimiter string before splitting the workflow file, and refining the regular expression used to extract the subgraph IPFS hash to avoid capturing intermediate file hashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
Run 31622196197 exposed two independent first-deploy failures. Graph CLI received an
ECONNRESETwhile Graph Node was activating the uploaded subgraph, leaving no active version. The deployment archive was extracted underumask 077, andcp -apreserved a mode-0700 BENS directory, so the official BENS image user could not readconfig.json.Validation
python -m unittest discover -s .github/scripts/tests -p 'test_*.py'- 24 passedpython scripts/validate-testnet-bens.pyactionlint.exe .github/workflows/deploy-config.yml .github/workflows/dependency-build.ymldocker compose ... config -q/bin/sh -ngit diff --checkhttps://test.doscan.io/api/v2/stats