fix(testnet): target canonical blockchain RPC - #181
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Code Review
This pull request updates the Testnet blockchain ID from the retired hash to the canonical hash across multiple configuration files, environment variables, documentation, and validation scripts. It also introduces automated validation checks and corresponding unit tests to ensure all runtime RPC targets consistently use the canonical blockchain. The feedback suggests referencing the blockchain hash constants directly from the imported module in the test file to eliminate duplication and prevent future desync issues.
| canonical_blockchain = ( | ||
| "JASJZyVTWR7aviy4eY5yE8AVfdXtH33c1AinvzhLcVBARhcm9" | ||
| ) | ||
| retired_blockchain = ( | ||
| "2EhCz8u48mSCUzxEEGsqY7d1PnqUKkc2B1zkTQaJxbT99wshkJ" | ||
| ) |
There was a problem hiding this comment.
The blockchain hash constants canonical_blockchain and retired_blockchain are duplicated here from scripts/validate-testnet-bens.py. Since the test class dynamically imports the validation script and stores it in self.module, you can reference these constants directly from self.module to avoid duplication and prevent future desync issues when the blockchain targets are updated.
canonical_blockchain = self.module.CANONICAL_TESTNET_BLOCKCHAIN\n retired_blockchain = self.module.RETIRED_TESTNET_BLOCKCHAIN
Summary
Validation