Skip to content

fix(testnet): target canonical blockchain RPC - #181

Merged
JOY (JOY) merged 2 commits into
mainfrom
codex/testnet-rpc-canonical
Aug 12, 2026
Merged

fix(testnet): target canonical blockchain RPC#181
JOY (JOY) merged 2 commits into
mainfrom
codex/testnet-rpc-canonical

Conversation

@JOY

Copy link
Copy Markdown

Summary

  • route Testnet HTTP, WebSocket, backend, and user-ops RPC traffic to the canonical JASJZyVT blockchain
  • identify the public RPC origin as dos-testnet-r0-JASJZyVT
  • add a regression validator that rejects the retired 2EhCz blockchain target
  • update the architecture source of truth

Validation

  • 29 Python tests passed
  • Testnet BENS validator passed
  • Blockscout environment parity passed
  • Docker Compose config passed
  • pinned Caddy image validation passed
  • actionlint passed
  • git diff --check passed

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Testnet blockchain ID from the retired hash to the canonical hash across multiple configuration files, environment variables, documentation, and validation scripts. It also introduces automated validation checks and corresponding unit tests to ensure all runtime RPC targets consistently use the canonical blockchain. The feedback suggests referencing the blockchain hash constants directly from the imported module in the test file to eliminate duplication and prevent future desync issues.

Comment on lines +88 to +93
canonical_blockchain = (
"JASJZyVTWR7aviy4eY5yE8AVfdXtH33c1AinvzhLcVBARhcm9"
)
retired_blockchain = (
"2EhCz8u48mSCUzxEEGsqY7d1PnqUKkc2B1zkTQaJxbT99wshkJ"
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The blockchain hash constants canonical_blockchain and retired_blockchain are duplicated here from scripts/validate-testnet-bens.py. Since the test class dynamically imports the validation script and stores it in self.module, you can reference these constants directly from self.module to avoid duplication and prevent future desync issues when the blockchain targets are updated.

        canonical_blockchain = self.module.CANONICAL_TESTNET_BLOCKCHAIN\n        retired_blockchain = self.module.RETIRED_TESTNET_BLOCKCHAIN

@JOY
JOY (JOY) merged commit 46e0885 into main Aug 12, 2026
12 checks passed
@JOY
JOY (JOY) deleted the codex/testnet-rpc-canonical branch August 12, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant