Code Notes: replace the architecture diagram with a corrected SVG - #4377
Open
Zia-research wants to merge 1 commit into
Open
Code Notes: replace the architecture diagram with a corrected SVG#4377Zia-research wants to merge 1 commit into
Zia-research wants to merge 1 commit into
Conversation
code-notes.adoc renders LinuxCNC-block-diagram-small.png, unchanged in the repository since 2012-11-19 (b60c201). This adds a hand-written SVG with the same topology and ten corrections, each established by reading master at caa13ca, and points the image directive at it. Nothing is removed: both PNGs stay in place, including the Spanish variant that the translation catalogue maps to. The corrections are listed with their source locations at https://zia-research.github.io/linuxcnc-audit/sheets/linuxcnc-code-notes-errata.html Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code-notes.adoc:103showsLinuxCNC-block-diagram-small.png, unchanged in the repository since 2012-11-19 (b60c20198e). This replaces it with a hand-written SVG: same topology, with corrections — they are listed here: https://zia-research.github.io/linuxcnc-audit/sheets/linuxcnc-code-notes-errata.html@grandixximo proposed extracting this figure as a standalone
.svgin #3718. This is not the continuation of #3718 — that PR updatesLinuxCNC-block-diagram.png, a different file.Nothing is deleted: the PNGs stay in the tree, only the
image::line changes. Say the word if you would rather I remove the superseded ones.I will fix it according to your feedback. For the future, it is plain SVG so anyone can edit it.
With the help of AI