feat: add loopstructural-visualisation as packages/loopstructural_visualisation workspace package - #301
Open
lachlangrose wants to merge 2 commits into
Open
Conversation
This was referenced Aug 14, 2026
…ualisation workspace package Ports the loopstructural-visualisation repo in as a uv-workspace member, following the src-layout pattern proven by packages/loop_common and packages/loop_interpolation in Stage 2. Import name stays loopstructuralvisualisation; only the on-disk container path changes. - Routed the one print() call in __init__.py's trame-ui import guard through LoopStructural.utils.getLogger, consistent with the rest of the ecosystem's logging conventions. - Left LoopStructural.datatypes imports in _3d_viewer.py as-is rather than swapping to LoopStructural.geometry: that module only exists in this repo's unreleased dev tree, not in any published LoopStructural release, and the package's declared floor is LoopStructural>=1.6.17. (cherry picked from commit 07f0868)
lachlangrose
force-pushed
the
split/02-visualisation-package
branch
from
August 14, 2026 11:14
0db8c7d to
ad714cd
Compare
…uv.sources packages/* workspace glob makes any package dir under packages/ a uv workspace member automatically, but uv separately requires each member to have a tool.uv.sources entry declaring it as workspace = true. Missing entries broke uv sync/build for every package in this repo with: "loopstructuralvisualisation is included as a workspace member, but is missing an entry in tool.uv.sources". LoopStructural is needed too since loopstructuralvisualisation depends on LoopStructural>=1.6.17 and should resolve that against the local workspace root, not PyPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #298 / #299. PR 2 of 9 in the stack — depends on #300.
Adds the
loopstructural_visualisationpackage (2D/3D viewers, trame UI) as a new self-contained workspace member underpackages/loopstructural_visualisation. No wiring into the root workspace config yet — that's PR 4 (#303 stack, once opened).Base is #300 only because of stack ordering; this package's content doesn't depend on the intrusions fix.