refactor: extract ModelSerializer from GeologicalModel - #305
Merged
lachlangrose merged 1 commit intoAug 14, 2026
Merged
Conversation
This was referenced Aug 14, 2026
GeologicalModel mixed recipe/pickle I/O in with feature-construction orchestration, evaluation, and export logic (2580 lines total). Move the recipe/JSON and dill/pickle serialization logic into a standalone ModelSerializer, keeping every GeologicalModel public method as a thin unchanged-signature wrapper so the CI-enforced stable API surface (API.md, tests/unit/test_public_api_contract.py) is unaffected. (cherry picked from commit 404ce4b)
lachlangrose
force-pushed
the
split/06-extract-model-serializer
branch
from
August 14, 2026 11:29
a4c9ee2 to
82ace86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #298 / #299. PR 6 of 9 in the stack — depends on #304.
First of four sequential extractions breaking
GeologicalModelapart. Moves serialization logic (save/load) out ofgeological_model.pyinto a new_model_serializer.py.