refactor: extract FeatureRelationshipManager from GeologicalModel - #307
Open
lachlangrose wants to merge 1 commit into
Open
Conversation
Move fault/unconformity relationship bookkeeping (_add_faults, _add_domain_fault_above/below, _add_unconformity_above, add_unconformity, add_onlap_unconformity) into a standalone FeatureRelationshipManager, continuing the GeologicalModel decomposition. Public methods remain unchanged thin wrappers; _add_feature stays on GeologicalModel since it owns features/feature_name_index mutation directly. (cherry picked from commit b7f2197)
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #298 / #299. PR 8 of 9 in the stack — depends on #306.
Third of four sequential extractions. Moves feature-relationship bookkeeping out of
geological_model.pyinto a new_model_relationships.py.