Destroy nvexec ensure_started completion storage before freeing it - #2189
Open
fallintoplace wants to merge 2 commits into
Open
Destroy nvexec ensure_started completion storage before freeing it#2189fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
fallintoplace
marked this pull request as draft
August 11, 2026 16:44
fallintoplace
force-pushed
the
fix/nvexec-ensure-started-destruction
branch
from
August 11, 2026 19:45
d05453e to
639fe05
Compare
Collaborator
|
why is this a draft PR? |
Collaborator
|
/ok to test 639fe05 |
Contributor
Author
|
I want to check until I am sure that everything is working correctly and there is no hidden regression. |
fallintoplace
force-pushed
the
fix/nvexec-ensure-started-destruction
branch
from
August 11, 2026 20:07
639fe05 to
5f0df5b
Compare
fallintoplace
marked this pull request as ready for review
August 11, 2026 20:17
fallintoplace
force-pushed
the
fix/nvexec-ensure-started-destruction
branch
from
August 11, 2026 20:32
5f0df5b to
02729eb
Compare
fallintoplace
marked this pull request as draft
August 11, 2026 20:32
fallintoplace
marked this pull request as ready for review
August 11, 2026 20:32
Collaborator
|
/ok to test 02729eb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
ensure_startedplacement-constructs its completion storage in managed memory. The shared state freed that memory without running the variant destructor, so the active completion value was never destroyed.The direct stream path copies the completion asynchronously. Its recorded event now synchronizes that copy before host destruction. If recording the event fails after the copy is queued, destruction synchronizes the stream instead.