fix(ffi): allow assignment over lazy metadata globals - #60
Merged
Conversation
Lazy globals were installed getter-only (JS_DefinePropertyGetSet with an undefined setter in the QuickJS engine path, and a get-only accessor in the shared JSI install script), and the resolved cache was defined non-writable. Any strict-mode assignment to a global whose name collides with a metadata symbol threw 'no setter for property' — @nativescript/core does exactly that in globals/index.js (global.System = ...), so apps died during bootstrap. Give lazy globals a setter that replaces the accessor with an ordinary writable property, matching plain global-assignment semantics, and make the resolved cache writable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
NathanWalker
marked this pull request as ready for review
August 9, 2026 17:00
DjDeveloperr
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazy globals were installed getter-only (JS_DefinePropertyGetSet with an
undefined setter in the QuickJS engine path, and a get-only accessor in the
shared JSI install script), and the resolved cache was defined non-writable.
Any strict-mode assignment to a global whose name collides with a metadata
symbol threw 'no setter for property' — @nativescript/core does exactly that
in globals/index.js (global.System = ...), so apps died during bootstrap.
Give lazy globals a setter that replaces the accessor with an ordinary
writable property, matching plain global-assignment semantics, and make the
resolved cache writable.
Found while bringing @nativescript/core up on the ios-quickjs runtime flavor. All fixes in this series were validated together on the iOS 26.5 simulator using a SolidJS + dominative app boots, renders, and runs stably with all of them applied.
🤖 Generated with Claude Code