Add search bar to new top nav (tied to old search functionality) - #3348
Conversation
|
Pull request environment is available at https://stoctodocspr3348.z22.web.core.windows.net. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
There was a problem hiding this comment.
Note a lot of this is just copied from the old Search.astro, it's mainly the design that's new
enf0rc3
left a comment
enf0rc3
left a comment
There was a problem hiding this comment.
Looks good, Assume we are waiting on responsive design still and this will change the shape of the search bar etc.
Appreciate the query param to conditionally show the header too, nice touch.
I tested and confirmed the Ctrl+K in windows.
one super trivial (wont fail pr on), is there is a resize of the input when you click it on hover that moves the side buttons.
20260813-0055-45.1038884.mp4
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| width="12" | ||
| height="12" | ||
| viewBox="0 0 11 11" | ||
| fill="currentColor" | ||
| aria-hidden="true" | ||
| > | ||
| <path | ||
| d="M7.585 5.5L10.7122 2.37281C11.0959 1.98906 11.0959 1.36687 10.7122 0.982812L10.0172 0.287813C9.63344 -0.0959375 9.01125 -0.0959375 8.62719 0.287813L5.5 3.415L2.37281 0.287813C1.98906 -0.0959375 1.36688 -0.0959375 0.982813 0.287813L0.287813 0.982812C-0.0959375 1.36656 -0.0959375 1.98875 0.287813 2.37281L3.415 5.5L0.287813 8.62719C-0.0959375 9.01094 -0.0959375 9.63312 0.287813 10.0172L0.982813 10.7122C1.36656 11.0959 1.98906 11.0959 2.37281 10.7122L5.5 7.585L8.62719 10.7122C9.01094 11.0959 9.63344 11.0959 10.0172 10.7122L10.7122 10.0172C11.0959 9.63344 11.0959 9.01125 10.7122 8.62719L7.585 5.5Z" | ||
| ></path> | ||
| </svg> |
There was a problem hiding this comment.
Consider using an icon for this for consistency
There was a problem hiding this comment.
I agree, but this is just copy pasted from the old Search.astro and was not part of the new design, so I don't expect this to stay. I definitely think that whatever this might end up being replaced with should be an icon, but as is I'd rather keep it as a copy paste so it stands out like the sore thumb that it is :D
Thanks, I can't seem to repro on Firefox or Chrome but I might be able to fix it regardless, I'll take a look |
|
Excellent progress @rosslovas 🎉 Is it possible to have the search bar align with the page content? |
95b5e83 to
6956d2f
Compare
I can indeed, it should be aligned now whenever the viewport width allows for it :) 
|
|
:chef: that's soooo satisfying. Thanks so much! |
5 participants
Summary
Implements a search bar into the new top nav. It's still linked to the old search experience (and also reuses the same
Xto clear your input from the old search bar) so it's a bit janky and still WIP, but it's usable.Results
Try it out at: https://stoctodocspr3348.z22.web.core.windows.net/docs?newnav
Screen.Recording.2026-08-13.at.9.44.24.am.mov
Also, verify the original header (still used in production) and its search functionality still works at: https://stoctodocspr3348.z22.web.core.windows.net/docs?newnav=0