Skip to content

compiletest -Zbuild-dir-new-layout support - #642

Merged
Firestar99 merged 2 commits into
mainfrom
build-dir-new-layout
Aug 10, 2026
Merged

compiletest -Zbuild-dir-new-layout support#642
Firestar99 merged 2 commits into
mainfrom
build-dir-new-layout

Conversation

@Firestar99

@Firestar99 Firestar99 commented Aug 10, 2026

Copy link
Copy Markdown
Member

See https://blog.rust-lang.org/2026/03/13/call-for-testing-build-dir-layout-v2/

Will be enabled by default starting nightly-2026-07-31.

Only affects our compiletest infra, since spirv-builder uses cargo metadata to query target dir location to only append ./target/spirv-builder.

@eddyb eddyb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mechanism was already pretty hacky, whatever it takes to keep it working seems fine to me (long-term the new build dir layout might allow some interesting caching AIUI, unsure how that will interact with anything else we do).

@Firestar99
Firestar99 force-pushed the build-dir-new-layout branch from 98a25bb to b1b4261 Compare August 10, 2026 15:42
@Firestar99
Firestar99 marked this pull request as ready for review August 10, 2026 16:22
@Firestar99
Firestar99 requested a review from LegNeato as a code owner August 10, 2026 16:22
@Firestar99
Firestar99 added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit b07b852 Aug 10, 2026
23 checks passed
@Firestar99
Firestar99 deleted the build-dir-new-layout branch August 10, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants