Specify maximum static size for component value types - #688
Open
ANAMASGARD wants to merge 2 commits into
Open
Conversation
Require resolved type AST nodes to satisfy elem_size <= 2^28 - 1 for both i32 and i64 pointer types using overflow-safe validation, closing fixed-length-list sizing hazards (WebAssembly#682). Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
Apply despecialize at each recursive check_resolved_type_size call so nested map/option/record nodes are validated, not only top-level types. Add regression tests for option<map<...>> and record fields (WebAssembly#682). Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #682
Summary
Adds a spec-defined maximum static value size of
2^28 - 1bytes for Component Model value types.Validation now:
i32andi64pointer types;Includes Python and WAST regression tests for fixed-length lists, compound types, nested maps, pointer-width differences, and integer-overflow cases.
The WAST test remains in
nyi.txtuntil wasm-tools/Wasmtime implement the corresponding validator rule.