GH-50665: [Python] Assert s3fs selector result count - #50836
Open
erichanwang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The recursive selector branch for the fsspec S3 backend evaluated
len(infos) == 4without asserting the result. As a result, an incorrect number of returned entries could pass the test unnoticed.What changes are included in this PR?
Fixes #50665.
Are these changes tested?
Yes. The modified test file passes Python syntax compilation, and
git diff --checkpasses. The focused runtime test could not run locally because this checkout does not have the pyarrow test dependencies installed.Are there any user-facing changes?
No. This change only strengthens an existing Python filesystem test.