UI: expose network ACL replacement from VPC tiers

[Dogface2k]

Summary

Expose the existing replaceNetworkACLList action beside each ACL in the VPC tiers overview.

This is an additional entry point to the existing guest-network action. It does not add another modal, form, API call, async-job poller, refresh path, or notification path.

Implementation

• Resolve the registered guest-network replaceNetworkACLList action from router metadata.
• Reuse its existing arguments, ACL-list mapping, submission, async-job polling, refresh, notification, and documentation behavior.
• Bind the registered ACL and network mapping functions to the selected tier.
• Keep the parent VPC as the action view resource so opening the action does not replace the VPC detail page resource with a tier.
• Fail closed when the API permission, registered action, visibility/disabled policy, or required mappings are unavailable.
• Leave the existing replace-ACL action on the tier detail page unchanged.

Scope

• UI-only change for the current main development line (4.23.0.0-SNAPSHOT).
• No linked issue; this is a UI enhancement.
• No server, API, schema, ACL-semantics, dependency, workflow, or CI configuration changes.
• No new translation keys.

Validation

Validated locally on candidate 0c36798508e655a7ee3cd1ee6f6ba7b8c57b31ac with Node.js 16.20.2 and the committed lockfile:

• Focused suite: 1 suite, 8 tests passed, 0 snapshots.
• Full UI unit suite: 5 suites, 183 tests passed, 0 snapshots.
• Full UI lint: no errors.
• Production UI build: completed successfully; only the repository's existing bundle-size warnings were reported.
• git diff --check: clean.
• Merge-tree check against Apache GitBox main at dd3427d91401f820ba5746403696a6146ab42328: conflict-free.
• Controlled fault: binding networkid to the parent VPC instead of the selected tier failed for the intended reason (tier-id expected, vpc-id received), then passed after restoring the canonical tier binding.

UI QA

• UI QA build passed: QA-JID-975.
• Live QA environment: https://qa.cloudstack.cloud/simulator/pr/13794
• Verified in a headed Google Chrome session through VPC -> Admin VPC -> Networks.
• Confirmed the shortcut appears beside each tier ACL, displays the Replace ACL tooltip, opens the existing canonical replacement form, and loads ACL choices scoped to the selected VPC.
• Cancelled without submitting an infrastructure mutation; the simulator baseline remained unchanged.

Current candidate

• PR/fork head: 0c36798508e655a7ee3cd1ee6f6ba7b8c57b31ac
• Target: Apache CloudStack main at dd3427d91401f820ba5746403696a6146ab42328
• Exact range: dd3427d91401f820ba5746403696a6146ab42328..0c36798508e655a7ee3cd1ee6f6ba7b8c57b31ac
• One commit, two intended files, clean worktree, conflict-free merge-tree.

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.92%. Comparing base (4f11707) to head (4f9b7ea).

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13794      +/-   ##
============================================
+ Coverage     19.65%   20.92%   +1.27%     
+ Complexity    19792    19791       -1     
============================================
  Files          6368     5881     -487     
  Lines        574881   533014   -41867     
  Branches      70351    62439    -7912     
============================================
- Hits         112970   111537    -1433     
+ Misses       449639   409403   -40236     
+ Partials      12272    12074     -198     

Flag	Coverage Δ
uitests	?
unittests	20.92% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

@Dogface2k
can you share a screenshot ?

there is already an icon to replace ACL list

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13794 (QA-JID-970)

[DaanHoogland]

@weizhouapache there is now also a button in the vpc tiers overview list. I think that is fine as well.

(edit: your sshot is from the tiers details page, this is extra)

[Dogface2k]

isolating VPC tier ACL replacement state

[DaanHoogland]

Now you have me worried @Dogface2k . there is a lot of new code while the functionality was already there in a different place. Do we now have two implementations of the same function?

[Dogface2k]

Now you have me worried @Dogface2k . there is a lot of new code while the functionality was already there in a different place. Do we now have two implementations of the same function?

Investigating it looks like we got duplicate stuff, agents went rouge in their new environments not sure why it continued to touch this PR xD

My agents will return back to their main environments soon. Currently maxed out but over next few days will have full reasoning back and this duplicate shit won't happen it has pin pointed it and is rectifying it as we speak. Was always a risk setting up new environments. The constant auditing I have on every PR even when approved seem to of triggered another review that then led Two independent UI workflows and Duplicate form/API/polling logic @DaanHoogland

[Dogface2k]

@blueorangutan ui

[blueorangutan]

@Dogface2k a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13794 (QA-JID-975)

[DaanHoogland]

@Dogface2k , just out of interest, have you found the existing “change acl list” functionality? and can they be unified?