[fix](binlog) Parse table stream properties before base validation - #66683
Open
luwei16 wants to merge 1 commit into
Open
[fix](binlog) Parse table stream properties before base validation#66683luwei16 wants to merge 1 commit into
luwei16 wants to merge 1 commit into
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: CREATE STREAM validated the base table with the stream object default MIN_DELTA type before parsing the requested stream properties. This incorrectly rejected valid APPEND_ONLY and DETAIL streams on UNIQUE or PRIMARY ROW-binlog tables that did not meet MIN_DELTA historical-value requirements. Parse and apply the stream properties before performing type-dependent base-table validation, while preserving the validation for real MIN_DELTA streams.
### Release note
Fix CREATE STREAM so APPEND_ONLY and DETAIL streams are validated using their requested type instead of the default MIN_DELTA type.
### Check List (For Author)
- Test:
- Unit Test: ./run-fe-ut.sh --run org.apache.doris.catalog.CreateTableStreamTest,org.apache.doris.cloud.datasource.CloudInternalCatalogTableStreamTest (passed: 9 tests)
- Regression test: ./run-regression-test.sh --run -d table_stream_p0 -s test_create_append_only_stream_without_historical_value (passed: 1 suite)
- Behavior changed: Yes. Valid APPEND_ONLY and DETAIL streams are no longer rejected by MIN_DELTA-only prerequisites.
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
gavinchou
approved these changes
Aug 12, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: CREATE STREAM validated the base table with the stream object default MIN_DELTA type before parsing the requested stream properties. This incorrectly rejected valid APPEND_ONLY and DETAIL streams on UNIQUE or PRIMARY ROW-binlog tables that did not meet MIN_DELTA historical-value requirements. Parse and apply the stream properties before performing type-dependent base-table validation, while preserving the validation for real MIN_DELTA streams.
Release note
Fix CREATE STREAM so APPEND_ONLY and DETAIL streams are validated using their requested type instead of the default MIN_DELTA type.
Check List (For Author)