[fix](fe) Select S3 storage for cloud plugin downloads - #66695
Open
CalvinKirs wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#58968 Problem Summary: Cloud SaaS JDBC catalogs that reference a driver by bare file name download it from the instance object store. StorageProperties.createAll now places its default HDFS properties first, but CloudPluginDownloader selected the first entry and cast it to AbstractS3CompatibleProperties, causing a ClassCastException before the driver could be downloaded. Select the first actual S3-compatible properties by type instead of list position, and fail explicitly when no compatible object storage is available. ### Release note Fix automatic JDBC driver and Java UDF jar downloads from Cloud SaaS instance object storage. ### Check List (For Author) - Test: Unit Test - MAVEN_OPTS="-Xmx4g -XX:MaxMetaspaceSize=1g" FE_UT_PARALLEL=1 ./run-fe-ut.sh --run org.apache.doris.common.plugin.CloudPluginDownloaderTest (production and test sources compiled; 9 tests discovered, but execution was blocked by the existing Mockito inline MockMaker because Byte Buddy could not self-attach to this JDK) - Behavior changed: Yes (cloud plugin downloads now select S3-compatible properties even when default HDFS properties are first) - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
CalvinKirs
marked this pull request as ready for review
August 12, 2026 10:18
Member
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: In Cloud SaaS mode, a JDBC catalog or Java UDF using a bare jar name downloads the file from the instance object store.
StorageProperties.createAll()now prepends a default HDFS entry, whileCloudPluginDownloaderselected the first entry and cast it toAbstractS3CompatibleProperties. The cast therefore failed withClassCastExceptionbefore the download. This change selects the first explicitly S3-compatible property by type and fails clearly if none exists. Tests cover default-HDFS ordering, all current S3-compatible property implementations, and the missing-compatible-storage path.Release note
Fix automatic JDBC driver and Java UDF jar downloads from Cloud SaaS object storage when the plugin is referenced by a bare file name.
Check List (For Author)
MAVEN_OPTS="-Xmx4g -XX:MaxMetaspaceSize=1g" FE_UT_PARALLEL=1 ./run-fe-ut.sh --run org.apache.doris.common.plugin.CloudPluginDownloaderTestcompleted Checkstyle, FE main compilation, and test compilation. All 9 tests were blocked in the existing Mockito setup because Byte Buddy cannot self-attach to the current JDK; there were no assertion failures.