share batchesBuf across merge iterators via MergeWorkspace - #7765
Draft
PaurushGarg wants to merge 1 commit into
Draft
share batchesBuf across merge iterators via MergeWorkspace#7765PaurushGarg wants to merge 1 commit into
PaurushGarg wants to merge 1 commit into
Conversation
PaurushGarg
force-pushed
the
fix/shared-batches-buf-v2
branch
from
August 14, 2026 23:50
cb83e77 to
3fb8a9c
Compare
Signed-off-by: Paurush Garg <paurushg@amazon.com>
PaurushGarg
force-pushed
the
fix/shared-batches-buf-v2
branch
from
August 15, 2026 01:13
3fb8a9c to
9706212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Each
mergeIteratorallocates its ownbatchesBufat creation time. This adds to the heap profile for query engines that create all iterators upfront, especially with high-cardinality queries - while only one buffer is actively used at a time since series are processed sequentially.Add
MergeWorkspaceis a shared buffer that multiple merge iterators can borrow instead of allocating their own.batchesBufis scratch space used only duringbuildNextBatch()and overwritten every call.buildNextBatchlazily allocates its own buffer if no workspace is passed.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags