Return kill() result - #333
Open
PNHD wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #255.
Summary
return the boolean result from childProcess.kill() through PythonShell.kill()
keep terminated synchronized with the same result
add regression coverage that asserts kill() returns true when the signal is sent successfully
Testing
reproduced the current bug with a focused TypeScript contract test: the existing return this behavior fails the boolean-return assertion
compiled and ran the patched contract with strict TypeScript checks; verified true, false, signal forwarding, and deprecated terminate() alias behavior
verified the unified diff applies cleanly against the exact current HEAD snippets used by index.ts and test/test-python-shell.ts
The full repository test suite was not run locally because this execution environment could not reach the npm registry. Repository CI should run the normal npm test matrix once the PR is opened.