ci-queue: Recover when the Redis queue master dies during setup - #98
Draft
kstewartfigma wants to merge 2 commits into
Draft
ci-queue: Recover when the Redis queue master dies during setup#98kstewartfigma wants to merge 2 commits into
kstewartfigma wants to merge 2 commits into
Conversation
Author
|
Codex update: reviewed the failed Ruby matrix and fixed it in All four jobs failed in The fix routes only that follower wait through the existing Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the longstanding failure mode discussed in Slack: if the worker elected to populate the Redis queue dies while
master-statusissetup, every surviving worker currently waits until it raisesCI::Queue::Redis::LostMaster.Proof
Added regression coverage for:
Validation:
test/ci/queueunit suitegit diff --checkpassesLocal Ruby 3.4 still has the repository's six existing RSpec output-fixture failures caused by Ruby 3.4 changing backtrace quoting. The repository's CI matrix intentionally runs Ruby 3.0–3.3.