Skip to content

feat(dataconnect): update "X-Client-Version" header value to match the Node/Admin/{version} convention - #3230

Merged
dconeybe merged 1 commit into
mainfrom
dconeybe/dataconnect/ClientVersionConformance
Aug 13, 2026
Merged

feat(dataconnect): update "X-Client-Version" header value to match the Node/Admin/{version} convention#3230
dconeybe merged 1 commit into
mainfrom
dconeybe/dataconnect/ClientVersionConformance

Conversation

@dconeybe

Copy link
Copy Markdown
Contributor

No description provided.

@dconeybe dconeybe self-assigned this Aug 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'X-Client-Version' header value from 'node/{version}' to 'Node/Admin/{version}' in the Data Connect API client, and updates the corresponding unit tests to reflect this change. There are no review comments, and I have no additional feedback to provide.

@dconeybe
dconeybe marked this pull request as ready for review August 13, 2026 17:35
@dconeybe
dconeybe requested a review from jonathanedey August 13, 2026 17:35

@stephenarosaj stephenarosaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanedey jonathanedey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@dconeybe
dconeybe merged commit 97bff0f into main Aug 13, 2026
20 checks passed
@dconeybe
dconeybe deleted the dconeybe/dataconnect/ClientVersionConformance branch August 13, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants