fix(mcp): restore hosted keyless Parse safety boundaries - #334
Merged
Conversation
hmishra2250
force-pushed
the
fix/hosted-keyless-parse-zdr
branch
from
July 26, 2026 18:41
520d4b7 to
c8ace28
Compare
hmishra2250
force-pushed
the
fix/hosted-keyless-parse-zdr
branch
from
July 26, 2026 18:42
c8ace28 to
f302d83
Compare
hmishra2250
marked this pull request as ready for review
July 26, 2026 18:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zeroDataRetention: trueafter anonymous/keyless session resolution and before any Core eligibility, upload, or Parse endpoint callredactPIIavailable to anonymous Parse and correct hosted Parse guidance/examplesScope
MCP server only. No Core, DB, Infra, endpoint-routing, or Stage-1/2 contract changes.
Regression lineage
The intended guard and tests existed before the PR #308 train but were omitted during the pre-merge reconciliation. This restores the established contract on current
main, without a blind revert.Verification
npm run buildnpm test: 43/43 passnpm run lintnpx tsc --noEmitgit diff --checkRelease verification after merge
firecrawl-mcp-serverauto-deploys via GHCR/Keel. From a clean eligible network, verify anonymous tools/list still shows exactly Search/Scrape/Parse; verify anonymous ZDR returns a structured error with no upload instructions; then run a small non-sensitive two-phase Parse fixture and an API-key Parse smoke. Do not log credentials, signed URLs, or upload refs.Follow-up outside this PR
Infra/security should independently audit lifecycle handling for uploaded-but-never-parsed objects before making stronger retention claims.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Restores the hosted keyless Parse ZDR boundary and tightens client IP trust. Anonymous keyless can still use
redactPII;zeroDataRetention: trueis denied and multi鈥慼op/privateX-Forwarded-Foris not trusted; authenticated sessions can use ZDR.zeroDataRetentionin anonymous keyless Parse before any upload or backend call; returnsKEYLESS_OPTION_NOT_AVAILABLEwith guidance.X-Forwarded-For; otherwise reject keyless withKEYLESS_ACCESS_NOT_AVAILABLE. Forward the trusted IP to/v2/keyless/eligibility.redactPIIfor keyless and updatefirecrawl_parsedocs/examples to note ZDR requires an account or API key.redactPII; early ZDR rejection; reject multi-hop/private XFF; ZDR allowed and forwarded for API key and managed OAuth sessions.Written for commit f302d83. Summary will update on new commits.