feat(core): Make ISpan startChild SpanOptions overloads public - #5927
Merged
Conversation
Unmark the SpanOptions-based startChild overloads on ISpan so callers can set an explicit start timestamp without using internal API. Co-Authored-By: Roman Zavarnitsyn <roman.zavarnitsyn@sentry.io>
Contributor
|
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6b019b7 | 343.31 ms | 417.23 ms | 73.91 ms |
| d15471f | 286.65 ms | 314.68 ms | 28.03 ms |
| d217708 | 409.83 ms | 474.72 ms | 64.89 ms |
| d500866 | 326.13 ms | 378.70 ms | 52.58 ms |
| fcec2f2 | 314.96 ms | 373.66 ms | 58.70 ms |
| d501a7e | 314.55 ms | 343.34 ms | 28.79 ms |
| 7414e9b | 322.49 ms | 378.88 ms | 56.39 ms |
| fcec2f2 | 357.47 ms | 447.32 ms | 89.85 ms |
| a416a65 | 316.52 ms | 359.67 ms | 43.15 ms |
| 983e0f0 | 350.64 ms | 386.44 ms | 35.79 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6b019b7 | 0 B | 0 B | 0 B |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| d217708 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| d500866 | 0 B | 0 B | 0 B |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| d501a7e | 0 B | 0 B | 0 B |
| 7414e9b | 0 B | 0 B | 0 B |
| fcec2f2 | 1.58 MiB | 2.12 MiB | 551.50 KiB |
| a416a65 | 1.58 MiB | 2.12 MiB | 555.26 KiB |
| 983e0f0 | 0 B | 0 B | 0 B |
romtsn
marked this pull request as ready for review
August 10, 2026 23:04
romtsn
requested review from
0xadam-brown,
adinauer,
markushi,
romtsn and
runningcode
as code owners
August 10, 2026 23:04
romtsn
enabled auto-merge (squash)
August 11, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Remove
@ApiStatus.Internalfrom theseISpanoverloads:startChild(operation, description, spanOptions)startChild(spanContext, spanOptions)Add public Javadoc for both. Implementations are unchanged.
💡 Motivation and Context
Callers that only have an
ISpan(for exampleSentry.getExtendedAppStartSpan()) need a stable public way to start a child with an explicit start timestamp.SpanOptionsis already public and supportssetStartTimestamp. Making these overloads public closes that gap without promoting theInstrumenteroverloads.Fixes #5896
💚 How did you test it?
:sentry:spotlessJavaApply:sentry:apiDump(no binary API signature change; annotation-only)📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Requested by Roman Zavarnitsyn.
--
View Junior Session [Sentry]