ext/curl: improved tests - #23183
Conversation
Follow up to php#22908.
|
Is this just to make it look neat, or is there a risk that the wrong exception is thrown? |
Regression protection. See the in progress effort in #22799; it's something that gets often flagged. |
|
@Sjord As you are the author of that piece of code, do you think this change is good to go? |
|
Oh, and @NickSdot Since people constantly forget about applying these new error test styles, do you think it is reasonable to mention them in CODING_STANDARD.md? If you think so, feel free to open a PR, Cheers :) |
Good idea! PR incoming.
My point exactly; that's why I think unifying is important. :) |
|
It seems these changes are also in #23038. Perhaps it's better to close this one and continue with #23038? I think these changes are fine. These tests already catch a ValueError so I can't see this going wrong easily, but it's nice to have this checked and consistent. The commit message could use some more detail. |
Follow up to #22908.