Enable x11 feature by default in processing_pyo3 - #224
Open
pepc84 wants to merge 2 commits into
Open
Conversation
added 2 commits
August 8, 2026 09:22
The workspace Cargo.toml already enables x11 by default, but processing_pyo3 has its own default features that didn't include x11. This meant building with maturin from the sub-crate would produce a Wayland-only wheel even on X11 systems. Add x11 to processing_pyo3's default features to match the workspace.
Contributor
Author
|
The CI failures are pre-existing. I checked out main without my changes and ran cargo clippy locally, same v4l2-sys-mit error in the webcam crate shows up. Nothing to do with this PR. |
Slightly related to that, is formatting failing on main too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace Cargo.toml already enables x11 by default, but processing_pyo3 has its own default features that didn't include x11. This meant building with maturin from the sub-crate would produce a Wayland-only wheel even on X11 systems.
Add x11 to processing_pyo3's default features to match the workspace.