Make cli tests run in parallel - #1045
Conversation
| else | ||
| PULP_CA_BUNDLE="/usr/local/share/ca-certificates/pulp_webserver.crt" make livetest PYTEST_MARK="live and ({{ cli_plugin_markers }})" | ||
| PULP_CA_BUNDLE="/usr/local/share/ca-certificates/pulp_webserver.crt" make paralleltest PYTEST_MARK="live and ({{ cli_plugin_markers }})" | ||
| fi |
There was a problem hiding this comment.
This looks like a "is this cli new enough" heuristic. But I believe it's not accurate anymore.
What we can do however (by the new power of uv), is ignore the version of pulp_glue installed for pulpcore completely and run the cli (always the latest release) in an isolated environment.
WDYT?
There was a problem hiding this comment.
Which line are you talking about? 166? I'm not sure what you are asking for.
There was a problem hiding this comment.
The whole if "test_requirements.txt".
Which is i think rooted in the fact that since pulpcore chooses one version of glue the one of the cli was pinned. But with an isolated environment, we can make that obstacle go away completely. And we would never need to touch an old cli branch because some plugin CI happened to install from it again.
There was a problem hiding this comment.
The original if check was because plugins with their own CLI didn't all have the new uv logic in their repo. Maven and ostree still both don't have it. I'll go update them and then update this.
2 participants
https://redhat.atlassian.net/browse/PULP-2236
📜 Checklist
See: Pull Request Walkthrough