Skip to content

gh-118318: Remove outdated c14n references from ElementTree - #118319

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
danifus:cleanup-removed-c14n
Aug 9, 2026
Merged

gh-118318: Remove outdated c14n references from ElementTree#118319
serhiy-storchaka merged 5 commits into
python:mainfrom
danifus:cleanup-removed-c14n

Conversation

@danifus

@danifus danifus commented Apr 26, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Some references to a removed c14n serialization method remained in ElementTree.py. Attempting to use method='c14n' in the write() method would result in ValueError: unknown method 'c14n'.

Removes the write_c14n() method that uses method='c14n' and also raises the same error.

@danifus
Remove outdated c14n references from ElementTree
3d03255 
Some references to a removed `c14n` serialization method remained in
ElementTree.py. Attempting to use `method='c14n'` in the `write()`
method would result in `ValueError: unknown method 'c14n'`.

Removes the `write_c14n()` method that uses `method='c14n'` and also
raises the same error.
@bedevere-app bedevere-app Bot mentioned this pull request Apr 26, 2024
Closed
@github-actions

github-actions Bot commented Apr 16, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 16, 2026
serhiy-storchaka
serhiy-storchaka requested changes May 25, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a NEWS entry and a What's New entry for this change.

Comment thread Lib/xml/etree/ElementTree.py Outdated
@bedevere-app

bedevere-app Bot commented May 25, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 30, 2026
serhiy-storchaka
serhiy-storchaka approved these changes Aug 9, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added NEWS and What's NEW. LGTM now.

@read-the-docs-community

read-the-docs-community Bot commented Aug 9, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33983594 | 📁 Comparing f40f26a against main (5107fd7)

  🔍 Preview build  

2 files changed
± whatsnew/3.16.html
± whatsnew/changelog.html

@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) August 9, 2026 20:35
@serhiy-storchaka
serhiy-storchaka merged commit 87b120f into python:main Aug 9, 2026
99 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danifus @serhiy-storchaka