gh-155194: Fix not raising on non-module import - #155189
Open
DinoV wants to merge 3 commits into
Open
Conversation
DinoV
changed the title
DinoV
marked this pull request as ready for review
August 4, 2026 22:49
DinoV
requested review from
AA-Turner,
FFY00,
Yhg1s,
brettcannon,
emmatyping,
ericsnowcurrently,
erlend-aasland,
itamaro,
kumaraditya303,
ncoghlan,
pablogsal and
warsaw
as code owners
August 4, 2026 22:49
encukou
reviewed
Aug 10, 2026
Comment on lines
4597
to
4605
| if (fromlist && PyTuple_Check(fromlist) && PyTuple_GET_SIZE(fromlist)) { | ||
| for (Py_ssize_t i = 0; i < PyTuple_GET_SIZE(fromlist); i++) { | ||
| if (register_from_lazy_on_parent(tstate, abs_name, | ||
| PyTuple_GET_ITEM(fromlist, i)) < 0) | ||
| { | ||
| goto error; | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Would it make sense to also remove this, so that math instead of math.pi shows up in sys.lazy_modules?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As initially reported here: https://discuss.python.org/t/sys-lazy-modules-clarification/108385
lazy import math.pihas divergent behavior fromimport math.pi. Currently we allow this to work and just give you themathmodule. Instead we should raiseModuleNotFoundErrorbecausemath.piis not a module.lazy import math.pi#155194