gh-155336: Preserve resolver errors from gethostby*_r() - #155337
Merged
serhiy-storchaka merged 4 commits intoAug 10, 2026
Conversation
serhiy-storchaka
added
needs backport to 3.13
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM, but please add a NEWS entry.
Contributor
Author
|
Ah, yes - I added a NEWS entry. |
serhiy-storchaka
approved these changes
Aug 10, 2026
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM. 👍
BTW, some of these issues I was able to reproduce on OpenIndiana.
|
Thanks @kulikjak for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-155469 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
Sorry, @kulikjak and @serhiy-storchaka, I could not cleanly backport this to |
|
GH-155470 is a backport of this pull request to the 3.14 branch. |
|
GH-155473 is a backport of this pull request to the 3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-155336.
This change captures the error from all variants into
h_error(depending on the way it should be captured) and later uses it ingethost_common().Tested on Oracle Solaris - I am now getting a correct error:
>>> import socket >>> socket.gethostbyaddr('1.2.3.4') Traceback (most recent call last): File "<python-input-1>", line 1, in <module> socket.gethostbyaddr('1.2.3.4') ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^ socket.herror: [Errno 1] Unknown host