gh-155436: Fix configparser.getboolean() for value-less options - #155437
Open
lpyu001 wants to merge 1 commit into
Open
gh-155436: Fix configparser.getboolean() for value-less options#155437lpyu001 wants to merge 1 commit into
lpyu001 wants to merge 1 commit into
Conversation
picnixz
reviewed
Aug 9, 2026
| """ | ||
| if value is None: | ||
| raise ValueError('Not a boolean: None') | ||
| if value.lower() not in self.BOOLEAN_STATES: |
Member
There was a problem hiding this comment.
Suggested change
| if value.lower() not in self.BOOLEAN_STATES: | |
| if value is None or value.lower() not in self.BOOLEAN_STATES: |
picnixz
reviewed
Aug 9, 2026
Comment on lines
+1225
to
+1226
| if value is None: | ||
| raise ValueError('Not a boolean: None') |
Member
There was a problem hiding this comment.
Suggested change
| if value is None: | |
| raise ValueError('Not a boolean: None') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configparser.getboolean()raisesAttributeErrorfor a value-less option #155436