bpo-26571: Reinit class variable _RUNNING - #30355
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
This PR is stale because it has been open for 30 days with no activity. |
|
@serhiy-storchaka @ethanfurman PR became stale |
github-actions
Bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
Initialising the class variable at the end of the object initialisation method. This will help to run this library smoothly in use cases such as in notebooks or GUI or other cell based or multiple turtle object instance execution. Otherwise it will raise Terminator error every second time. Will solve problems highlighted repeatedly in these stack overflow posts (With 1000s of views, current suggestions are some non-elegant workarounds such as importlib.reload(turtle) or or try-except and initializing again in the except as the _RUNNING becomes false at the end of last run or manually setting the _RUNNING flag). Logical to turn this to True after the initialization rather than during terminator exception. Change tested extensively and no issues found in any of the turtle-demo examples, notebooks or usual self-contained single instance execution. https://stackoverflow.com/questions/45534458/python-turtle-terminator-even-after-using-exitonclick https://stackoverflow.com/questions/34956937/weird-terminator-error-when-running-python-3-turtle-in-os-x https://stackoverflow.com/questions/70252586/turtle-module-for-langtons-ant-in-python-giving-me-raise-terminator-turtle-ter https://stackoverflow.com/questions/58078376/a-function-i-created-can-only-be-called-once-second-time-it-shows-an-error https://stackoverflow.com/questions/54198108/how-can-i-close-a-window-after-using-turtle https://stackoverflow.com/questions/67734319/running-turtle-multiple-times-but-receiving-a-terminator-error-after-the-first-r https://stackoverflow.com/questions/43294665/turtle-done-not-working-in-spyder https://stackoverflow.com/questions/50438762/python-turtle-window-crashes-every-2nd-time-running https://stackoverflow.com/questions/41644324/how-to-close-python-turtle-properly https://stackoverflow.com/questions/41548813/using-turtle-module-exitonclick/70552164 https://stackoverflow.com/questions/66750634/why-do-i-get-a-terminator-error-when-i-run-this-program https://stackoverflow.com/questions/65546812/python-turtle-terminator https://stackoverflow.com/questions/61963565/why-do-i-keep-getting-a-terminator-error-for-python-turtle
c3b456a to
4d574e0
Compare
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. Rebased and cleaned up the comment and NEWS.
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @williamnavaraj for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-155449 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-155450 is a backport of this pull request to the 3.14 branch. |
|
GH-155451 is a backport of this pull request to the 3.13 branch. |
5 participants
Initialising the class variable at the end of the object initialisation method. This will help to run this library smoothly in use cases such as in notebooks or GUI or other cell based or multiple turtle object instance execution. Otherwise it will raise Terminator error every second time. Will solve problems highlighted repeatedly in these stack overflow posts (With 1000s of views, current suggestions are some non-elegant workarounds such as importlib.reload(turtle) or or try-except and initializing again in the except as the _RUNNING becomes false at the end of last run or manually setting the _RUNNING flag). Logical to turn this to True after the initialization rather than during terminator exception. Change tested extensively and no issues found in any of the turtle-demo examples, notebooks or usual self-contained single instance execution.
https://stackoverflow.com/questions/45534458/python-turtle-terminator-even-after-using-exitonclick
https://stackoverflow.com/questions/34956937/weird-terminator-error-when-running-python-3-turtle-in-os-x
https://stackoverflow.com/questions/70252586/turtle-module-for-langtons-ant-in-python-giving-me-raise-terminator-turtle-ter
https://stackoverflow.com/questions/58078376/a-function-i-created-can-only-be-called-once-second-time-it-shows-an-error
https://stackoverflow.com/questions/54198108/how-can-i-close-a-window-after-using-turtle
https://stackoverflow.com/questions/67734319/running-turtle-multiple-times-but-receiving-a-terminator-error-after-the-first-r
https://stackoverflow.com/questions/43294665/turtle-done-not-working-in-spyder
https://stackoverflow.com/questions/50438762/python-turtle-window-crashes-every-2nd-time-running
https://stackoverflow.com/questions/41644324/how-to-close-python-turtle-properly
https://stackoverflow.com/questions/41548813/using-turtle-module-exitonclick/70552164
https://stackoverflow.com/questions/66750634/why-do-i-get-a-terminator-error-when-i-run-this-program
https://stackoverflow.com/questions/65546812/python-turtle-terminator
https://stackoverflow.com/questions/61963565/why-do-i-keep-getting-a-terminator-error-for-python-turtle
https://bugs.python.org/issue26571