build(deps): pin GitPython>=3.1.58 to resolve GHSA-9rj7-rf2p-w77r, GHSA-wvpp-8hx9-p66j - #349
Open
katsugtgz wants to merge 1 commit into
Open
build(deps): pin GitPython>=3.1.58 to resolve GHSA-9rj7-rf2p-w77r, GHSA-wvpp-8hx9-p66j#349katsugtgz wants to merge 1 commit into
katsugtgz wants to merge 1 commit into
Conversation
…p66j GHSA-9rj7-rf2p-w77r: Unguarded git option forwarding in Repo.init enables arbitrary command execution via --template clone hooks (CVE pending, HIGH severity) GHSA-wvpp-8hx9-p66j: Unsafe git option guard bypass via split_single_char_options=False short-option token smuggling enables command execution (HIGH severity, CVSS 8.8) Both fixed in GitPython 3.1.58. This pins the minimum version in tools_requirements.txt to ensure installs resolve to a patched release. No application logic changes.
Member
|
We don't pass untrusted input to these functions, I don't see how we are vulnerable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin minimum GitPython version in
tools_requirements.txtto resolve two recent HIGH-severity advisories:GHSA-9rj7-rf2p-w77r:
Repo.init()forwards**kwargstogit initwith no unsafe-option guard. An attacker-controlledtemplatekwarg can plant hooks that execute on the next git operation, enabling arbitrary command execution.GHSA-wvpp-8hx9-p66j: The
check_unsafe_optionsguard can be bypassed on all guarded methods viasplit_single_char_options=Falseshort-option token smuggling, enabling command execution at defaultallow_unsafe_options=False.Both fixed in GitPython 3.1.58.
Change
Single line change in
tools_requirements.txt. No application logic affected.Verification
Scanned with osv-scanner before and after: