[aiofiles] Fix NamedTemporaryFile name type - #16162
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13551
What problem this solves
aiofiles.tempfile.NamedTemporaryFile()currently exposesnameas the broadFileDescriptorOrPathtype, unlike the named temporary-file API it wraps.Why this change
The general async file wrappers must retain their broad
nametype becauseaiofiles.open()accepts file descriptors and path-like values. This adds private named-temporary-file wrapper types that narrow onlyNamedTemporaryFile()results tostr.User impact
Type checkers now accept string-specific operations on
file.nameinside both binary and textNamedTemporaryFile()context managers.Evidence
source .venv/bin/activate && python tests/runtests.py stubs/aiofiles --run-stubtest