Update specification for directives for sys.implementation and sys.platform checks. - #2173
Update specification for directives for sys.implementation and sys.platform checks.#2173Josverl wants to merge 4 commits into
Conversation
|
|
||
| * Equality: ``sys.platform == "linux"`` | ||
| * Inequality: ``sys.platform != "win32"`` | ||
| * Membership: ``sys.platform in ("linux", "darwin")`` |
There was a problem hiding this comment.
I'm not convinced that containment should be supported here. There's already a way to express this in a way that all tools today support. I understand the argument that this is less verbose, but it's not that common for checks to include more than one platform, so I don't think there's a compelling argument to force all tools to support this additional form.
There was a problem hiding this comment.
For deciding on issues like this it would be helpful to have a little summary of what type checkers currently support (like what I did in https://discuss.python.org/t/spec-change-clarify-that-tuple-should-not-be-prohibited-as-an-argument-to-type/105590/7). I'll gather a few variants and summarize it.
I think part of this change will be codifying what is already supported universally, and another part will be adding support for more features. The first group should be uncontroversial, and in the second group we should only force work on type checker authors if there's a clear use case.
There was a problem hiding this comment.
If possible this would really help with creating readable and maintainable type stubs for MicroPython.
even with the proposed sys.implementation.name check we still see significant API differences due the underlying MCU vendor SDKs being significantly different.
Though MicroPython tries to abstract much of these differences away that is not entirly possible as the underlying SDK or hardware is simply different. This is a common source of errors when code is ported from one MCU architecture to another.
For instance Timers are available on all platforms, but with many different default values.
While the below would work
# machine.pyi
class Timer():
""""Timer object"""
if sys.implementation.name == "micropython" and (sys.platform == "esp32" or sys.platform == "mimxrt" or sys.platform == "rp2" or sys.platform == "samd" or sys.platform == "stm32" or sys.platform == "alif" or sys.platform == "webassembly"):
@overload
def __init__(
self,
id: int,
/,
*,
mode: int = PERIODIC,
period: int | None = None,
callback: Callable[[Timer], None] | None = None,
hard: bool | None = None,
):...
elif sys.implementation.name == "micropython" and (sys.platform == "esp8266" or sys.platform == "unix" or sys.platform == "windows" or sys.platform == "zephyr"):
@overload
def __init__(
self,
id: int = -1,
/,
*,
mode: int = PERIODIC,
period: int | None = None,
callback: Callable[[Timer], None] | None = None,
):...the below is much simpler to understand and maintain.
class Timer():
""""Timer object"""
if sys.implementation.name == "micropython" and (sys.platform in ("esp32", "mimxrt", "rp2", "samd", "stm32", "alif", "webassembly")):
@overload
def __init__(
self,
id: int,
/,
*,
mode: int = PERIODIC,
period: int | None = None,
callback: Callable[[Timer], None] | None = None,
hard: bool | None = None,
):...
elif sys.implementation.name == "micropython" and (sys.platform in ("esp8266", "unix", "windows", "zephyr")):
@overload
def __init__(
self,
id: int = -1,
/,
*,
mode: int = PERIODIC,
period: int | None = None,
callback: Callable[[Timer], None] | None = None,
):...I think it would be reasonable to explicitly restrict this to "a tuple of literal strings",assuming that simplies the implementation.
Negative membership option could also be omitted , I think that would still be sufficient.
There was a problem hiding this comment.
I fully agree with Eric here FWIW. Adding support for this will add significant complexity to type checkers, and this is the first time I've seen it requested. If we want to ask type checkers to add support for in/not in comparisons with sys.platform and sys.implementation.name, I think it should be a wholly separate proposal to the proposal that asks type checkers to add initial support for comparisons against sys.implementation.version and sys.implementation.name in the same way that they already do for sys.version_info and sys.platform.
|
|
||
| * Equality: ``sys.implementation.name == "cpython"`` | ||
| * Inequality: ``sys.implementation.name != "cpython"`` | ||
| * Membership: ``sys.implementation.name in ("pypy", "graalpy")`` |
There was a problem hiding this comment.
Here again, I don't think there's good justification for supporting a containment operator.
There was a problem hiding this comment.
I addedd this for consistency, but I'm OK to remove sys.implementation.name in ("pypy", "graalpy") from the spec to simplify the implementation.
4151e84 to
d7fbb9e
Compare
|
|
||
| Supported patterns: | ||
| * ``sys.platform <comparison> <string literal>`` | ||
| * ``sys.platform in <tuple of string literals>`` |
There was a problem hiding this comment.
the not / and / or are described further down to avoid neededing to repeat then for every possible clause, although != is repeated.
I could move that section to the top if that is clearer.
Multiple comparisons can be combined with:
* A not unary operator
* An and or or binary operator
There was a problem hiding this comment.
That's different, it would allow not (sys.platform in ("a", "b")), not sys.platform not in ("a", "b").
There was a problem hiding this comment.
I see your point, then I think it is clearer to just enumerate all option directly,
Supported patterns:
* ``sys.platform == <string literal>``
* ``sys.platform != <string literal>``
* ``sys.platform in <tuple of string literals>``
* ``sys.platform not in <tuple of string literals>``
d7fbb9e to
62d90dc
Compare
|
I have updated the text to better clarify the exact comparisons for each of the supported attributes, |
62d90dc to
ff338e3
Compare
|
Dear TC, If so kindly let me know how to proceed. |
JelleZijlstra
left a comment
There was a problem hiding this comment.
I'm generally supportive but I think this change needs some more editing, and I'd like support in at least some type checkers (at least an open PR) before we start mandating this pattern.
…atform checks. Signed-off-by: Jos Verlinde <Jos.Verlinde@Microsoft.com>
Formatting improvements. Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
…sion comparisons. Signed-off-by: Jos Verlinde <Jos_Verlinde@hotmail.com>
c575c15 to
c951b00
Compare
|
Dear typing council, However now it appears that this PR is in a Catch-22 situation; Lacking response I plan close this in a few weeks |
| * ``sys.platform in <tuple of string literals>`` | ||
| * ``sys.platform not in <tuple of string literals>`` |
There was a problem hiding this comment.
Ruff (PLR6201) will report an error for this tuple membership check, and I tend to agree with ruff that a set literal would be more idiomatic here.
There was a problem hiding this comment.
In the wild I've seen things like sys.platform.startswith("freebsd") a couple of times, because in this case there's also a version number in the platform string (e.g. "freebsd8"). So how about we also allow sys.platform.startswith(<string literal>)?
| * ``sys.version_info >= <2-tuple>`` | ||
| * ``sys.version_info < <2-tuple>`` | ||
|
|
||
| Comparisons checks are only supported against the first two elements of the version tuple. |
There was a problem hiding this comment.
As I mentioned a while back in https://discuss.python.org/t/proposal-to-improve-support-for-other-python-platforms-in-the-typing-specification/91877/13, there are genuine use cases for also comparing against the patch version, e.g. in typeshed: https://github.com/python/typeshed/blob/4f84ac178fb23541475f9038840c5b149834374f/stdlib/heapq.pyi#L9-L11
So I propose we loosen this restriction to also allow for 3-tuples.
| else: | ||
| # Python 3.11 and lower |
There was a problem hiding this comment.
It might be good to include elif in this example, so that it's clear that elif is also expected to be supported, and not just if and else. For example as:
| else: | |
| # Python 3.11 and lower | |
| elif sys.version_info >= (3, 11): | |
| # Python 3.11.* | |
| else: | |
| # Python 3.10 and lower |
| Configuration | ||
| ^^^^^^^^^^^^^ | ||
|
|
||
| Type checkers should provide configuration or CLI options to specify target sys.version, sys.platform, sys.implementation.name and sys.implementation.version. |
There was a problem hiding this comment.
| Type checkers should provide configuration or CLI options to specify target sys.version, sys.platform, sys.implementation.name and sys.implementation.version. | |
| Type checkers should provide configuration or CLI options to specify target ``sys.version``, ``sys.platform``, ``sys.implementation.name`` and ``sys.implementation.version``. |
This is not the case at all. It is very typical for type checkers to implement features even if they are not in the spec. It is very helpful to have feedback from type checker authors to be able to understand potential problems with spec changes. I think this has worked quite well in the past.and if a feature is useful enough there is usually a type checker that will implement it. |
This PR adds additional detail to the specification for Version and Platform checking.
Specificially it aims to add support for typechers to add support for :
sys.implementation.nameReferences :