fix(virtualized-lists): invalidate content length on orientation change - #57871
Open
fallintoplace wants to merge 1 commit into
Open
fix(virtualized-lists): invalidate content length on orientation change#57871fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a list changes between vertical and horizontal layouts,
ListMetricsAggregatorresets its cell measurements but keeps_contentLength. That value belongs to the old scrolling axis. In horizontal RTL mode, it can then be used to calculate a cell offset before the new content layout is observed.This clears
_contentLengthduring horizontal orientation changes so RTL calculations wait for the new content length. The reset was present in the original orientation invalidation logic and was removed when bottom-up layout support was removed.Changelog:
[GENERAL] [FIXED] - Invalidate list content length when orientation changes.
Test Plan:
yarn jest packages/virtualized-lists/Lists/__tests__/ListMetricsAggregator-test.js --runInBand.