Remove legacy Belt CPPO generator - #8543
Merged
Merged
Conversation
cristianoc
force-pushed
the
remove-runtime-cppo
branch
from
August 10, 2026 09:34
b0d4aa5 to
b964b17
Compare
cristianoc
marked this pull request as ready for review
August 10, 2026 09:34
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cknitt
approved these changes
Aug 10, 2026
cristianoc
force-pushed
the
remove-runtime-cppo
branch
from
August 10, 2026 14:42
b964b17 to
64f0667
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8543 +/- ##
=======================================
Coverage 74.83% 74.83%
=======================================
Files 477 477
Lines 63311 63313 +2
=======================================
+ Hits 47380 47382 +2
Misses 15931 15931
🚀 New features to boost your workflow:
|
Base automatically changed from
replace-cppo-specializations-with-functors
to
master
August 10, 2026 15:30
Belt is a legacy API expected to be removed rather than developed further. Converting its frozen data-structure specializations to functors, or replacing CPPO with another generator, would add migration risk and maintenance machinery without improving the runtime users consume. The checked-in specialized .res and .resi files were regenerated before this change and verified to be current. Make those files the canonical sources, and remove the CPPO templates, regeneration script, package command, OPAM dependency, and obsolete formatter exclusions. Normal builds already consumed the checked-in files, so this does not change runtime code or output. Rename unrelated dotted-filename test inputs so no source or configuration references to CPPO remain. The changelog entries intentionally retain the name to document the removal across the stacked changes. Checks: make test; make checkformat; dune build @check; dune build --profile browser --build-dir ./_build_playground compiler/jsoo/jsoo_playground_main.bc.js; dune exec tests/ounit_tests/ounit_tests_main.exe Signed-off-by: Cristiano Calcagno <cristianoc@users.noreply.github.com>
cristianoc
force-pushed
the
remove-runtime-cppo
branch
from
August 10, 2026 15:30
64f0667 to
3a3928a
Compare
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8543 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Belt is a legacy API expected to be removed rather than developed further. Converting its frozen data-structure specializations to functors, or replacing CPPO with another generator, would add migration risk and maintenance machinery without improving the runtime users consume.
The checked-in specialized .res and .resi files were regenerated before this change and verified to be current. Make those files the canonical sources, and remove the CPPO templates, regeneration script, package command, OPAM dependency, and obsolete formatter exclusions. Normal builds already consumed the checked-in files, so this does not change runtime code or output.
Rename unrelated dotted-filename test inputs so no source or configuration references to CPPO remain. The changelog entries intentionally retain the name to document the removal across the stacked changes.
Checks: make test; make checkformat; dune build @check; dune build --profile browser --build-dir ./_build_playground compiler/jsoo/jsoo_playground_main.bc.js; dune exec tests/ounit_tests/ounit_tests_main.exe
Signed-off-by: Cristiano Calcagno cristianoc@users.noreply.github.com
Stack created with GitHub Stacks CLI • Give Feedback 💬