fix(rust) :: format the files cargo fmt could not see - #1378
Conversation
|
@lovasoa due to the |
lovasoa
left a comment
lovasoa
left a comment
There was a problem hiding this comment.
changing the formatting without changing the contributor and agent instructions or the ci does not really make sense to me
| # ignore commits from showing up on git diffs. | ||
|
|
||
| # === large formatting commits === | ||
| # TODO :: add commit once merged into mainline No newline at end of file |
There was a problem hiding this comment.
yes, this is to ignore the formatting commit so that the blame correctly attributes the person who wrote it rather than the person who formatted it. if you don't care about that I can take it out
| mod basic_auth_password; | ||
| mod basic_auth_username; | ||
| mod client_ip; | ||
| mod configuration_directory; | ||
| mod cookie; | ||
| mod current_working_directory; | ||
| mod environment_variable; | ||
| mod exec; | ||
| mod fetch; | ||
| mod fetch_with_meta; | ||
| mod hash_password; | ||
| mod header; | ||
| mod headers; | ||
| mod hmac; | ||
| mod link; | ||
| mod oidc_logout_url; | ||
| mod path; | ||
| mod persist_uploaded_file; | ||
| mod protocol; | ||
| mod random_string; | ||
| mod read_file_as_data_url; | ||
| mod read_file_as_text; | ||
| mod regex_match; | ||
| mod request_body; | ||
| mod request_body_base64; | ||
| mod request_method; | ||
| mod run_sql; | ||
| mod send_mail; | ||
| mod set_variable; | ||
| mod uploaded_file_mime_type; | ||
| mod uploaded_file_name; | ||
| mod uploaded_file_path; | ||
| mod url_encode; | ||
| mod user_info; | ||
| mod user_info_token; | ||
| mod variables; | ||
| mod version; | ||
| mod web_root; |
There was a problem hiding this comment.
no, we need the macro to be able to keep the files in the functions folder and the actual functions in sync. this is documented, we can't change the behavior without changing the instructions
2 participants
Motivation
cargo fmtsilently skipped all 38 files undersqlpage_functions/functions/.Description
Two commits in this PR.
959f73admoditems next to it. A function missingmodis a resolution error. An orphanedmodis a dead-code warning..git-blame-ignore-revsscaffold. We need to wait to merge into mainline to be able to pull the commit hash off mainline to ignore.a732ccacrunscargo fmt --all. committed in a separate commit so that it can be added to.git-blame-ignore-revs.Testing
n/a :: no behaviour changes