fix: bastion and machine reconcile defects

[Herbaert]

Summary

Fixes seven defects in the bastion and machine reconcile paths, each with a
regression test. All were found by running the provider against real STACKIT
infrastructure and by the Copilot review on #1; none are introduced by the
refactor — they exist on main too.

What was broken

Silent resource leaks

• ensureServer recreated a server for machines that had already bootstrapped
  and joined. The replacement replays the original bootstrap data, so it either
  never rejoins (different IP) or rejoins while Machine and Node keep
  pointing at the deleted server (same IP) — the latter reports a healthy 3/3
  cluster while carrying a dangling provider ID. Now surfaces an error instead
  of recreating.
• Bastion cleanup on deletion, and bastion teardown on enabled: false, were
  both gated on persisted status. A bastion whose status patch never landed was
  therefore never removed — in the disable case while the condition reported
  "bastion disabled" and port 22 stayed open. Both now follow intent; the
  tag-based lookups make this safe.

Security

• Changing allowedCIDRs never revoked the old rule: the rule set only ever
  grew, so narrowing the CIDR did not take access away from the previously
  allowed range. Rules are now reconciled in both directions.

Reconcile correctness

• The bastion security group was attached a second time after CreateServer
  had already included it, failing with 404 (no port yet) or 400 ("Duplicate
  items in the list") and aborting EnsureBastion before the public IP was
  assigned. The attach is kept — CreateServer short-circuits on an existing
  server, making it the only path that repairs a detached group — but is now
  idempotent.
• A CIDR listed twice produced two identical rules and a failing reconcile.
• Deleting a cluster whose credentials Secret was already gone left it in
  Terminating forever. A missing Secret can never be recovered from (it
  commonly disappears first during namespace teardown), so deletion now
  finalizes and emits a CleanupSkipped warning; invalid — i.e. fixable —
  credentials still block as before.

Status consistency

• Machine cloud failures left the legacy status.ready boolean true while the
  conditions said False.

Configuration

• cluster-template-bastion.yaml hardcoded replicas: 3, ignoring
  WORKER_MACHINE_COUNT.

Testing

Every fix ships with a test at the cheapest level that can actually observe it:
cloud unit tests (httptest against the STACKIT API) for the client defects,
envtest specs for the controller defects.

Each test was verified by reverting its fix and confirming the test fails at
the documented assertion — a test that passes for unrelated reasons proves
nothing. Coverage: cloud 39.1% → 56.3%, controller 70.2% → 71.1%.

The suite was also run end to end against real STACKIT infrastructure (cluster
lifecycle, providerID alignment, bastion), all green with no leaked resources.

Follow-ups not in this PR

• The recreate guard returns a non-retryable error but nothing sets a terminal
  failure, so without a MachineHealthCheck the Machine is never replaced;
  status.instanceState and addresses also keep describing the deleted
  server.
• allowedCIDRs are compared as strings, so a non-canonical prefix the API
  stores masked causes create/delete churn.
• The credentials Secret is not watched, so correcting an invalid one never
  re-reconciles the cluster.
• The StackitCluster → Machine watch matches Machine.spec.clusterName
  against the StackitCluster name, which only holds when both share a name.

[tuunit]

Couldn't we use writeJSON for this instead?

[tuunit]

Suggested change

	sweep := hasBastionStatus(sc.Status.Bastion) ||
	meta.FindStatusCondition(sc.Status.Conditions, infrav1.ClusterBastionReadyCondition) == nil
	if sweep {
	if hasBastionStatus(sc.Status.Bastion) || meta.FindStatusCondition(sc.Status.Conditions, infrav1.ClusterBastionReadyCondition) == nil {

[tuunit]

Why does this say "legacy" boolean?

[tuunit]

and by the whay the machine scope has a SetNotReady method