-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(sdk): watch-mode chat subscriptions survive quiet windows #4548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kathiekiwi
merged 36 commits into
feat/agent-storybook-gallery
from
fix/watch-mode-keepalive-tri-13065
Aug 12, 2026
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
27b04fb
fix(sdk): watch-mode chat subscriptions survive quiet windows (TRI-13…
kathiekiwi 574a84d
fix(sdk): stopping a turn is an owning-transport action, not an abort…
kathiekiwi 8aa997b
Merge remote-tracking branch 'origin/feat/agent-storybook-gallery' in…
kathiekiwi e4cd316
Merge remote-tracking branch 'origin/feat/agent-storybook-gallery' in…
kathiekiwi 0264812
merge: propagate review fixes from feat/agent-storybook-gallery
kathiekiwi fef7b43
fix(sdk): surface an error when a watch-mode turn is truncated by rec…
kathiekiwi a95973c
fix(sdk): jitter the chat reconnect backoff
kathiekiwi 8feedd2
merge: propagate wave-2 review fixes from feat/agent-storybook-gallery
kathiekiwi 22969ff
merge: propagate org-purge best-effort from feat/agent-storybook-gallery
kathiekiwi bdf01b0
fix(sdk): keep watch-mode chat streams open across turns and clear st…
kathiekiwi e5ede6f
test(sdk): cover watch-mode keepalive, reader-cancel, and budget-exha…
kathiekiwi c40e5f0
fix(sdk): guard controller.close() so a clean reader cancel emits no …
kathiekiwi 100eb36
merge: watch keepalive settle/cancel guards review-comment fixes
kathiekiwi 8c72806
merge: propagate review-comment fixes from feat/agent-storybook-gallery
kathiekiwi 24a978c
merge: propagate second-pass fixes from feat/agent-storybook-gallery
kathiekiwi cdc7b5f
merge: propagate server-changes consolidation from feat/agent-storybo…
kathiekiwi d9dc61e
chore(changeset): consolidate the chat keepalive changesets into one
kathiekiwi e394f20
merge: consolidate the two chat changesets into one
kathiekiwi 66eb3da
merge: propagate changeset consolidation and note restoration from fe…
kathiekiwi dfeffd8
merge: propagate base UI relocation + drizzle attribution
kathiekiwi 47983a6
merge: propagate the tsql linter test fix from feat/agent-storybook-g…
kathiekiwi 99f83d8
merge: propagate card-test relocation
kathiekiwi c1d851a
chore: merge feat/agent-storybook-gallery (main sync)
kathiekiwi 5810c80
chore: merge feat/agent-storybook-gallery (review fixes)
kathiekiwi b1814dc
fix(sdk): keep the successor stream's abort controller when an aborte…
kathiekiwi ae1a936
chore: merge feat/agent-storybook-gallery (review fixes round 2)
kathiekiwi a026776
fix(sdk): release the tab claim when the user stops generation
kathiekiwi e24e584
chore: merge feat/agent-storybook-gallery (review fixes round 3)
kathiekiwi 7f0b9a4
chore: merge feat/agent-storybook-gallery (review fixes round 3)
kathiekiwi 1fa556f
chore: merge feat/agent-storybook-gallery (composer escape follow-up)
kathiekiwi aad20c3
chore: merge feat/agent-storybook-gallery (main sync post-#4529)
kathiekiwi a8ee578
chore: merge feat/agent-storybook-gallery (review fixes)
kathiekiwi 8f3116a
chore: merge feat/agent-storybook-gallery (prompt re-send guard)
kathiekiwi 0a5d7a9
chore: merge feat/agent-storybook-gallery (main sync post-#4525)
kathiekiwi 550b717
chore: merge feat/agent-storybook-gallery (demo line-0 guard)
kathiekiwi e2948f1
feat(webapp): query boundary pinned end-to-end and a capped query ret…
kathiekiwi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/sdk": patch | ||
| --- | ||
|
|
||
| Fixed a race where quickly restarting a chat stream could break stop and reconnect for the new stream. Stopping a chat now also hands it back to your other tabs instead of leaving them read-only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/sdk": patch | ||
| --- | ||
|
|
||
| Watch-mode chat streams now survive quiet windows and keep delivering later turns, and a reply cut off by a lost connection now shows an error instead of appearing finished. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: feature | ||
| --- | ||
|
|
||
| The dashboard agent now comes with a monthly message allowance. A message that fails to send doesn't count against it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: feature | ||
| --- | ||
|
|
||
| Watches now respect your plan's limits: free plans can run a limited number of watches at once and for a shorter window, with a prompt to upgrade for more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: improvement | ||
| --- | ||
|
|
||
| Queries stay read-only, and the agent now stops after a few failed queries in a row and answers with what it found instead of spending the whole reply retrying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: fix | ||
| --- | ||
|
|
||
| When queries are queued up and one is turned away, you now get a clear "try again shortly" instead of an error that looks like a problem with the query itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Pull request bundles several unrelated features and fixes instead of one change
The change set mixes many unrelated pieces of work (the chat stream fix in
packages/trigger-sdk/src/v3/chat.ts:1804-1852) with a new monthly message allowance, watch plan limits, query read-only enforcement, a query retry cap and an investigation sweep backstop, so the repository's one-change-per-request rule is broken.Impact: Reviewers cannot evaluate or revert the stated fix independently of several unrelated behaviour changes shipped alongside it.
Which unrelated changes are bundled together
CONTRIBUTING.mdstates: "We only accept PRs that address a single issue. Please do not submit PRs containing multiple unrelated fixes or features."The stated intent covers only TRI-13065/TRI-13070 in
packages/trigger-sdk/src/v3/chat.ts. The diff additionally contains:apps/webapp/app/services/dashboardAgentQuota.server.ts,internal-packages/dashboard-agent-db/drizzle/0004_stale_corsair.sql,apps/webapp/app/components/dashboard-agent/message-quota.ts.apps/webapp/app/services/dashboardAgentWatchLimits.server.ts,apps/webapp/app/services/dashboardAgentWatches.server.ts:353-374.apps/webapp/app/services/queryService.server.ts:400,apps/webapp/app/routes/api.v1.query.ts:84-89.internal-packages/dashboard-agent/src/tool-api.ts:189-205.apps/webapp/app/services/dashboardAgentInvestigationSweep.server.ts:116-153,internal-packages/dashboard-agent-db/drizzle/0005_ambitious_mordo.sql.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.